Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous spell checking #26

Closed
astoilkov opened this issue Jun 26, 2015 · 13 comments
Closed

Synchronous spell checking #26

astoilkov opened this issue Jun 26, 2015 · 13 comments

Comments

@astoilkov
Copy link

Is there any way to make a synchronous spell check? The problem I am having is that I am using Atom/Electron platform to built cross platform desktop application and their requirement is to use synchronous spell checking.

Here is the code from their documentation:

require('web-frame').setSpellCheckProvider("en-US", true, {
  spellCheck: function(text) {
    // return true or false
  }
});

You have done amazing job with this library and I would really like to use it. Keep the good work.

@astoilkov
Copy link
Author

Another approach will be to introduce a synchronous method that just returns true/false if the word is correctly spelled.

@erusev
Copy link

erusev commented Jun 26, 2015

I'd also like to know that, thanks.

@nathanjsweet
Copy link
Collaborator

Sorry for the late reply. I will try to get to this soon, and it relates to #25 anyways. I am nearing the end of taking a few weeks off for personal reasons. When I am back in action I will create synchronous versions of all the methods.

@astoilkov
Copy link
Author

I got really excited when I saw your response. I can't wait to try out the synchronous spellchecking in action.

Happy coding.

@erusev
Copy link

erusev commented Jul 14, 2015

@nathanjsweet That's great! Thanks for the prompt response and I look forward to the new methods.

@astoilkov
Copy link
Author

Hi Nathan,

What is the status for this issue? We really want to use nodehun as our spell checking library. We are building Desktop application using Electron. We are working on the final touches for our application and we were wondering if you are going to be able to implement these methods.

@nathanjsweet
Copy link
Collaborator

I am currently working on it still. I will try to get it out by the end of this week.

@astoilkov
Copy link
Author

This is great news. Thanks a lot!

@nathanjsweet
Copy link
Collaborator

Done 428a262 and 95f79d4

@erusev
Copy link

erusev commented Jul 23, 2015

@nathanjsweet Thanks! This is fantastic!

@astoilkov
Copy link
Author

Hi,

I just finished the initial implementation of the spell checking in our application. The library worked flawlessly. Thank you very much for your effort.

Have a great day.

@nathanjsweet
Copy link
Collaborator

Are either of you interested in taking over this project?

@astoilkov
Copy link
Author

This is great project. However, we are not familiar with C++ programming and we can't help the project. Sorry. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants