Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration watcher timestamp issue #49

Closed
kober32 opened this issue Apr 5, 2021 · 0 comments · Fixed by #63
Closed

Expiration watcher timestamp issue #49

kober32 opened this issue Apr 5, 2021 · 0 comments · Fixed by #63
Assignees
Labels
bug Something isn't working

Comments

@kober32
Copy link
Member

kober32 commented Apr 5, 2021

In WMTOperationExpirationWatcher line 216, the timer needs to be scheduled for +1 second (or otherwise) because it can be fired before the actual expiration. This leads to the operation remaining in the UI.

For example, the timer was scheduled on the exact time of expiration but was fired before:

(lldb) po operationExpires.timeIntervalSince1970
1617645305.0

(lldb) po currentDate.timeIntervalSince1970
1617645304.999485

and since the difference is 0.000514984130859375 (greater than 0), the operation is not expired...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant