New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability for the user to comment on the documentation #254
feat: add ability for the user to comment on the documentation #254
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The preview doesn't seem to work. |
Sorry have to add envs in Vercel |
Don't think it would work in the preview as it's a different domain. |
Fine for me if it is working on prod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one question. Would it make sense to start discussions on this repo with the topic docs? This way we keep it all in one place. Website docs can go into the other repo. |
That's what I thought initially. |
We have one repo (https://github.com/wundergraph/comments) where we put the comments for the website (wundergraph.com). Should the comments on docs.wundergraph.com be handled on this repo here (wundergraph/wundergraph) or should they also go on the wundergraph/comments repo? |
I would prefer wundergraph/wundergraph. We can create a "Docs" category in discussions. |
…ithub.com:wundergraph/wundergraph into suvij/eng-178-add-comments-to-blog-docs-to-enable
Checklist
make test