Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability for the user to comment on the documentation #254

Merged
merged 5 commits into from Oct 18, 2022

Conversation

JivusAyrus
Copy link
Member

Checklist

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wundergraph-docs ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 2:07PM (UTC)

@github-actions github-actions bot added the npm label Oct 11, 2022
@StarpTech
Copy link
Collaborator

The preview doesn't seem to work.

@JivusAyrus
Copy link
Member Author

The preview doesn't seem to work.

Sorry have to add envs in Vercel

@JivusAyrus
Copy link
Member Author

JivusAyrus commented Oct 11, 2022

Don't think it would work in the preview as it's a different domain.
giscus.wundergraph.com has frame-ancestors 'self' wundergraph.com *.wundergraph.com;

@StarpTech
Copy link
Collaborator

Fine for me if it is working on prod.

Copy link
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jensneuse
Copy link
Member

Just one question. Would it make sense to start discussions on this repo with the topic docs? This way we keep it all in one place. Website docs can go into the other repo.

@JivusAyrus
Copy link
Member Author

That's what I thought initially.
What do you mean by "Website docs can go into the other repo."?

@jensneuse
Copy link
Member

That's what I thought initially. What do you mean by "Website docs can go into the other repo."?

We have one repo (https://github.com/wundergraph/comments) where we put the comments for the website (wundergraph.com).

Should the comments on docs.wundergraph.com be handled on this repo here (wundergraph/wundergraph) or should they also go on the wundergraph/comments repo?

@JivusAyrus
Copy link
Member Author

I would prefer wundergraph/wundergraph. We can create a "Docs" category in discussions.

…ithub.com:wundergraph/wundergraph into suvij/eng-178-add-comments-to-blog-docs-to-enable
@jensneuse jensneuse merged commit 7da3f75 into main Oct 18, 2022
@jensneuse jensneuse deleted the suvij/eng-178-add-comments-to-blog-docs-to-enable branch October 18, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants