Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add root path and UI #308

Merged
merged 7 commits into from Nov 3, 2022

Conversation

thisisnithin
Copy link
Member

@thisisnithin thisisnithin commented Nov 1, 2022

Checklist

image

@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
wundergraph-docs ⬜️ Ignored (Inspect) Nov 3, 2022 at 8:31AM (UTC)

@github-actions github-actions bot added the engine label Nov 1, 2022
@StarpTech
Copy link
Collaborator

Lovely. Only a minor thing: Could we use a different blue? It doesn't match so well with the pink. Maybe that blue from the "Why WunderGraph?" button from our landing?

pkg/node/node.go Outdated Show resolved Hide resolved
);
}
</style>
<script src="https://cdn.tailwindcss.com"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to enforce a version? I'm OK with it, but it could just break without notice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cant unfortunately.

pkg/node/nodetemplates/template.go Outdated Show resolved Hide resolved
pkg/node/nodetemplates/resources/index.gohtml Outdated Show resolved Hide resolved
pkg/node/nodetemplates/resources/index.gohtml Outdated Show resolved Hide resolved
@jensneuse
Copy link
Member

The playground will only be available if activated in the config.

@jensneuse
Copy link
Member

Can you add a tooltip on the server and node status that explains what "SKIP" or the other status results mean?

@jensneuse
Copy link
Member

The commit could actually be a link to the commit.

@jensneuse
Copy link
Member

Can you make 2 sections? One for status, one for build info, to make it clear that these are two different things.

@thisisnithin
Copy link
Member Author

Can you make 2 sections? One for status, one for build info, to make it clear that these are two different things.

Done

@StarpTech
Copy link
Collaborator

@thisisnithin I'll check this locally and merge it when everything looks good.

Copy link
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech merged commit f1b8c49 into main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants