Allow configuration of application deployment name

[greemo]

Problem

At the moment the deployment name is always "main". I want to be able to configure that.

Suggested solution

Add 'deployment' field to ApplicationConfig and Application, and use it in resolveConfig() instead of the hard-coded 'main'.

then a user could configure the deployment within configureWunderGraphApplication()

Alternatives

Possibly allow overriding via an environment variable.

Additional context

wundergraph/packages/sdk/src/configure/index.ts

Line 303 in 97b29f2

const name = 'main';

wundergraph/packages/sdk/src/definition/index.ts

Line 53 in 97b29f2

export interface ApplicationConfig {

[jensneuse]

You're right that this should be configurable. I think, a good place could be the Application object:

wundergraph/examples/simple/.wundergraph/wundergraph.config.ts

Line 73 in a41ffc5

name: 'app',

We could add a properly like "environment" or "deployment" that defaults to the currently checked out branch, if not set. Otherwise, it could be overwritten via string. But I'm not yet 100% sure. Need to discuss within the team. What's your opinion on this?

[greemo]

Yeah, adding it to the ApplicationConfig that is used to construct the Application feels like a natural place for it.

I think defaulting to branch may make deployment a bit tricky, as it affects the url.

I'd feel more comfortable with default to 'main' as it is, but can be overwritten by the applicationconfig.

It may make sense for the go server+hook server to consider an environment variable as well.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.