Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node)!: restructure server imports #497

Merged
merged 21 commits into from Dec 29, 2022

Conversation

StarpTech
Copy link
Collaborator

@StarpTech StarpTech commented Dec 27, 2022

This PR will restructure the import paths for the server component. In that way, the server does not require more modules and paths as needed. This has improved the cold start by multiple seconds.

TODO:

  • Updates testapps
  • Updates examples
  • Update docs

Checklist

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
wundergraph-docs ⬜️ Ignored (Inspect) Dec 29, 2022 at 5:26PM (UTC)

Copy link
Contributor

@Pagebakers Pagebakers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Only thing I see it the webhook example isn't updated (only the testapp)

Actually we need to update all examples and docs :)

@StarpTech
Copy link
Collaborator Author

StarpTech commented Dec 28, 2022

Great improvement! Only thing I see it the webhook example isn't updated (only the testapp)
Actually we need to update all examples and docs :)

Thanks! Yes, I will update all testapps in this PR, but examples after the release.

Copy link
Contributor

@Pagebakers Pagebakers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech merged commit ac277de into main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants