Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract typescript client from nextjs #72

Merged
merged 35 commits into from Aug 3, 2022
Merged

feat: extract typescript client from nextjs #72

merged 35 commits into from Aug 3, 2022

Conversation

Pagebakers
Copy link
Contributor

Checklist

@Pagebakers
Copy link
Contributor Author

Will move the client in the sdk package as discussed with Dustin.

@github-actions github-actions bot added the sdk label Jul 13, 2022
@Pagebakers
Copy link
Contributor Author

This is ready for review now.

The client can be imported from @wundergraph/sdk/client. The SDK doesn't export the client directly yet, since there are some conflicting types with the internal client.

@Pagebakers Pagebakers mentioned this pull request Jul 13, 2022
Merged
13 tasks
@Pagebakers
Copy link
Contributor Author

Added and update the Readme.

typesVersions seems to fix the type issues with exports. Imports from 'sdk/dist/...' work still as well.

@StarpTech I'd recommend you try this branch as well, to see if the new exports work on your machine too.

@StarpTech
Copy link
Collaborator

Great, I'll try it out.

@StarpTech
Copy link
Collaborator

Same error as in #78 (comment)

@vercel
Copy link

vercel bot commented Jul 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
wundergraph-docs ⬜️ Ignored (Inspect) Sep 2, 2022 at 10:50AM (UTC)

jensneuse
jensneuse requested changes Jul 20, 2022
View reviewed changes
packages/sdk/src/client/README.md Outdated Show resolved Hide resolved
packages/sdk/src/client/README.md Outdated Show resolved Hide resolved
StarpTech
StarpTech requested changes Aug 1, 2022
View reviewed changes
packages/sdk/src/client/index.ts Outdated Show resolved Hide resolved
packages/sdk/src/client/README.md Show resolved Hide resolved
packages/sdk/src/client/README.md Show resolved Hide resolved
packages/sdk/src/client/index.ts Show resolved Hide resolved
packages/sdk/src/client/index.ts Show resolved Hide resolved
packages/sdk/src/client/index.ts Show resolved Hide resolved
packages/sdk/src/client/index.ts Show resolved Hide resolved
packages/sdk/src/client/index.ts Outdated Show resolved Hide resolved
@StarpTech
Copy link
Collaborator

StarpTech commented Aug 1, 2022 •
edited

How / did you test the whole implementation? (Upload, Subscribe, ...)

@Pagebakers
Copy link
Contributor Author

How / did you test the whole implementation? (Upload, Subscribe, ...)

I tested all functionality (except subscriptions) using the nextjs-testapp

StarpTech
StarpTech approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pagebakers Pagebakers merged commit 282797d into main Aug 3, 2022
@Pagebakers Pagebakers deleted the eelco/eng-141-export-typescript-client-from-nextjs branch August 3, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

@jensneuse jensneuse jensneuse approved these changes

Assignees
No one assigned
Labels
nextjs npm sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pagebakers @StarpTech @jensneuse