Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring subfolders doesn't seem to work on locations defined in run_on #51

Open
tormi opened this issue Aug 18, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@tormi
Copy link
Member

tormi commented Aug 18, 2020

Ref: https://wunder.slack.com/archives/C5B9YGQSE/p1597407241011400

How can I define working ignore_patterns for folders which are subfolders of ones which are defined in run_on? This doesn’t seem to work:

    ecs:
      run_on: ['web/modules/custom', 'web/themes/custom', 'web/sites']
      ignore_patterns:
        - '/web/sites/default/files/'

Screenshot 2020-08-14 at 15 41 58 (1)

cc: @guncha25

@tormi tormi added this to To do in Code quality via automation Sep 11, 2020
@tormi tormi moved this from To do to In progress in Code quality Sep 11, 2020
@guncha25 guncha25 assigned hkirsman and unassigned guncha25 Sep 11, 2020
@guncha25 guncha25 added the bug Something isn't working label Sep 11, 2020
@tormi
Copy link
Member Author

tormi commented Apr 30, 2021

Still relevant:

    php_stan:
      run_on: ['web/modules/custom', 'web/themes/custom']

gave me

php_stan
========

PHP Warning:  file_get_contents(): Filename cannot be empty in /app/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php on line 43
Warning: file_get_contents(): Filename cannot be empty in /app/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit8/ClassWriter.php on line 43
Error thrown in /app/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/RunnerVersion.php on line 27 while loading bootstrap file /app/vendor/mglaman/phpstan-drupal/drupal-autoloader.php: Class 'PHPUnit\Runner\Version' not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Code quality
  
In progress
Development

No branches or pull requests

3 participants