Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Reflection natives are not implemented in lua backend #1051

Open
jlfarris91 opened this issue Mar 22, 2022 · 1 comment
Open

[Lua] Reflection natives are not implemented in lua backend #1051

jlfarris91 opened this issue Mar 22, 2022 · 1 comment

Comments

@jlfarris91
Copy link

image

image

image

@jlfarris91
Copy link
Author

After discussing with @peq and @Frotty it makes sense that instanceCount() and maxInstanceCount() would be challenging to implement in lua. Though, I suspect that maxTypeId and typeIdToTypeName implementations are reasonable.

I request that all of these functions are implemented with stub functions being implemented for instanceCount and maxInstanceCount that return 0.

I believe this would be more correct such that maps built using these standard library functions won't fail due to lack of implementation but, at least for the stub functions, would have "undefined" behavior as implied by the contract defined by the warning comment in the Reflection package.

@jlfarris91 jlfarris91 changed the title Reflection natives are not implemented in lua backend [Lua] Reflection natives are not implemented in lua backend Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants