get bookmark repository from dependency injection

zwwuu · Jan 20, 2021 · 9f67a29 · 9f67a29
1 parent 9ad26ed
commit 9f67a29
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 12 deletions.
diff --git a/lib/app/app_module.dart b/lib/app/app_module.dart
@@ -7,11 +7,13 @@ import 'app_widget.dart';
 import 'modules/bookmarks/bookmark_module.dart';
 import 'modules/home/home_module.dart';
 import 'modules/item/item_module.dart';
+import 'shared/repositories/bookmark_repository.dart';
 
 class AppModule extends MainModule {
   @override
   List<Bind> get binds => [
         $AppController,
+        $BookmarkRepository,
         Bind((i) => Dio(BaseOptions(baseUrl: 'http://api.hackerwebapp.com'))),
       ];
 

diff --git a/lib/app/modules/bookmarks/bookmark_controller.dart b/lib/app/modules/bookmarks/bookmark_controller.dart
@@ -10,21 +10,21 @@ part 'bookmark_controller.g.dart';
 class BookmarkController = _BookmarksControllerBase with _$BookmarkController;
 
 abstract class _BookmarksControllerBase with Store {
-  final BookmarkRepository _repository;
+  final BookmarkRepository _bookmarksRepository = Modular.get();
 
-  _BookmarksControllerBase(this._repository);
+  _BookmarksControllerBase();
 
   @observable
   ObservableList<FeedItem> bookmarks = ObservableList<FeedItem>();
 
   @action
   Future<void> loadBookmarks() async {
-    bookmarks.addAll(await _repository.getAll());
+    bookmarks.addAll(await _bookmarksRepository.getAll());
   }
 
   @action
   Future<void> deleteBookmark(FeedItem feedItem) async {
-    await _repository.delete(feedItem.key);
+    await _bookmarksRepository.delete(feedItem.key);
     bookmarks.remove(feedItem);
   }
 }
diff --git a/lib/app/modules/bookmarks/bookmark_controller.g.dart b/lib/app/modules/bookmarks/bookmark_controller.g.dart
diff --git a/lib/app/modules/bookmarks/bookmark_module.dart b/lib/app/modules/bookmarks/bookmark_module.dart
@@ -1,13 +1,11 @@
 import 'package:flutter_modular/flutter_modular.dart';
 
-import '../../shared/repositories/bookmark_repository.dart';
 import 'bookmark_controller.dart';
 import 'bookmark_page.dart';
 
 class BookmarkModule extends ChildModule {
   @override
   List<Bind> get binds => [
-        $BookmarkRepository,
         $BookmarkController,
       ];
 

diff --git a/lib/app/modules/home/home_controller.dart b/lib/app/modules/home/home_controller.dart
@@ -13,7 +13,7 @@ class HomeController = _HomeControllerBase with _$HomeController;
 
 abstract class _HomeControllerBase with Store {
   final HomeRepository _repository;
-  final BookmarkRepository _bookmarksRepository;
+  final BookmarkRepository _bookmarksRepository = Modular.get();
 
   int _currentPage = 1;
   List<FeedItem> feedItems = [];
@@ -30,7 +30,7 @@ abstract class _HomeControllerBase with Store {
   @observable
   bool isLoadingNextPage = false;
 
-  _HomeControllerBase(this._repository, this._bookmarksRepository);
+  _HomeControllerBase(this._repository);
 
   @action
   Future<void> loadFeedItems() async {

diff --git a/lib/app/modules/home/home_controller.g.dart b/lib/app/modules/home/home_controller.g.dart
diff --git a/lib/app/modules/home/home_module.dart b/lib/app/modules/home/home_module.dart
@@ -1,6 +1,5 @@
 import 'package:flutter_modular/flutter_modular.dart';
 
-import '../../shared/repositories/bookmark_repository.dart';
 import 'home_controller.dart';
 import 'home_page.dart';
 import 'repository/home_repository.dart';
@@ -10,7 +9,6 @@ class HomeModule extends ChildModule {
   List<Bind> get binds => [
         $HomeController,
         $HomeRepository,
-        $BookmarkRepository,
       ];
 
   @override