Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in line 264 of base_model.py #7

Closed
yaorz97 opened this issue Feb 19, 2023 · 1 comment
Closed

A bug in line 264 of base_model.py #7

yaorz97 opened this issue Feb 19, 2023 · 1 comment

Comments

@yaorz97
Copy link

yaorz97 commented Feb 19, 2023

The outputs of function shape_cd_loss should be transform_pt_cd_loss, pred_trans_pts, gt_trans_pts

@Wuziyi616
Copy link
Owner

Wuziyi616 commented Feb 19, 2023

Hi, thanks for pointing that out. It's fixed in the latest commit. This bug have no effect on the benchmark results, because neither the variables are used in the code.

However, this could be the reason why in my early experiments, adding an adversarial loss doesn't help the performance... I was inputting the GT- instead of the predicted- transformed shapes into the discriminator...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants