Allow user to specify a default sorting order in the rails helper #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Maybe you can add a test that covers this feature? |
|
👍 Looks good to me. |
|
@wvanbergen Hmm, I could write a test, but rails_helper isn't tested today -- I'd probably need to stub out every single method call inside sort because they're all from rails ActionView. What do you think? |
wvanbergen
added a commit
that referenced
this pull request
Mar 19, 2014
Allow user to specify a default sorting order in the rails helper
|
Stubbing out ActionView helpers is pretty shitty, but it turned out to be not too bad. I added a basic spec for the helper: d3776a4 Could you add a basic spec for the |
|
Absolutely! Opened #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the user may want the sort link to go to descending order first.