Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC Flatpak packaging #44

Open
tinywrkb opened this issue Nov 22, 2021 · 3 comments
Open

PoC Flatpak packaging #44

tinywrkb opened this issue Nov 22, 2021 · 3 comments

Comments

@tinywrkb
Copy link

Here's an initial Flatpak packaging manifest for GTKTerm.
The package can easily be built with Flatpak Builder.

I quickly tested the app with USB to TTL, and as far as I can tell, it's working as expected.

The following should be handled before considering publishing via Flathub.org:

  • The config file should be in XDG_CONFIG_HOME. HOME is the worst location for a config file because it mandates the use of the --persist=. permission, which is a bit buggy.
  • AppStream appdata/metainfo is missing.

Optional changes:

  • Use reverse DNS naming scheme for the installed desktop file and icon file names. e.g. com.github.Jeija.GTKTerm.desktop.
  • Evaluate and use the Device Portal to avoid the permissive --device=all permission.
@Jeija
Copy link
Collaborator

Jeija commented Dec 4, 2021

Hi @tinywrkb 👋 !

I'm certainly open to adding / improving Flatpak support and am happy for any help in that regard. Concerning the issue with the configuration file location, see my comment in #40.
Since I am not too familiar with how Flatpak handles permissions: With my suggested behavior, gtkterm checks if .gtktermrc exists in $HOME before potentially creating one in $XDG_CONFIG_HOME. I am wondering if checking for existence of the configuration file in $HOME will cause any issues with Flatpak support?

@tinywrkb
Copy link
Author

tinywrkb commented Dec 4, 2021

@Jeija thanks for solving the config file location issue.

I am wondering if checking for existence of the configuration file in $HOME will cause any issues with Flatpak support?

No, I don't see a reason why it will.

I tested fe66238 and it works as expected.

@Jeija
Copy link
Collaborator

Jeija commented Dec 4, 2021

Thanks for taking the time to test fe66238! I have now merged it into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants