Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<exclusions> should be part of <assembly> #74

Closed
Fitosoft opened this issue May 24, 2018 · 1 comment · Fixed by #97
Closed

<exclusions> should be part of <assembly> #74

Fitosoft opened this issue May 24, 2018 · 1 comment · Fixed by #97
Labels
good first issue

Comments

@Fitosoft
Copy link

In the plugin documentation there are examples stating that <exclusions> would be part of <assembly>. But in reality it seems <exclusions> are part of the higher level <configuration> element, which contradicts the documentation. To have <exclusions> parallel to <inclusions> seems a lot more intuitive too.
Thank you for considering my request.
@Fitosoft
Copy link
Author

... or otherwise please fix the documentation. Thx! :)

@lasselindqvist lasselindqvist mentioned this issue Jul 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue-74: Fix assembly and exclusions hierarchy in examples lasselindqvist/proguard-maven-plugin
2 participants
@lasselindqvist @Fitosoft