Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-http: Http client interface clean up #2231

Merged
merged 5 commits into from Jun 4, 2022
Merged

Conversation

xerial
Copy link
Member

@xerial xerial commented Jun 4, 2022

Follow-up work of #2230

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #2231 (0f7a5c5) into master (5613aa3) will not change coverage.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2231   +/-   ##
=======================================
  Coverage   82.61%   82.61%           
=======================================
  Files         313      314    +1     
  Lines       12428    12428           
  Branches      773      771    -2     
=======================================
  Hits        10268    10268           
  Misses       2160     2160           
Impacted Files Coverage Δ
...frame/http/codegen/client/RPCClientGenerator.scala 100.00% <ø> (ø)
...n/scala/wvlet/airframe/http/HttpClientConfig.scala 47.61% <ø> (ø)
...scala/wvlet/airframe/http/client/HttpClients.scala 72.82% <ø> (+2.11%) ⬆️
...ala/wvlet/airframe/http/client/ClientFactory.scala 42.85% <42.85%> (ø)
...et/airframe/http/client/URLConnectionChannel.scala 86.84% <91.30%> (ø)
...wvlet/airframe/http/client/JavaClientChannel.scala 96.96% <100.00%> (ø)
...cala/wvlet/airframe/http/HttpClientException.scala 77.21% <0.00%> (-1.27%) ⬇️
...me-log/src/main/scala/wvlet/log/io/StopWatch.scala 81.05% <0.00%> (+0.20%) ⬆️
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 85.18% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5613aa3...0f7a5c5. Read the comment docs.

@xerial xerial changed the title airframe-http: Fix RPC client generator airframe-http: Http client interface clean up Jun 4, 2022
@xerial xerial merged commit 439fb5b into master Jun 4, 2022
@xerial xerial deleted the fix-rpc-client branch June 4, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant