Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-rpc: #2368 Add RPCContext to access thread-local storage and http request #2369

Merged
merged 13 commits into from Aug 17, 2022

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 16, 2022

Closes #2368

@xerial xerial changed the title airframe-rpc: #2368 Add a common thread-local storage airframe-rpc: #2368 Add RPCContext to access thread-local storage and http request Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #2369 (db4d95a) into master (7127ac2) will increase coverage by 0.00%.
The diff coverage is 82.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2369   +/-   ##
=======================================
  Coverage   82.71%   82.72%           
=======================================
  Files         344      347    +3     
  Lines       13128    13154   +26     
  Branches      826      838   +12     
=======================================
+ Hits        10859    10881   +22     
- Misses       2269     2273    +4     
Impacted Files Coverage Δ
...rc/main/scala/wvlet/airframe/http/GrpcStatus.scala 87.87% <ø> (ø)
...rc/main/scala/wvlet/airframe/http/RPCContext.scala 25.00% <25.00%> (ø)
...vlet/airframe/http/finagle/FinagleRPCContext.scala 66.66% <66.66%> (ø)
...c/main/scala/wvlet/airframe/http/HttpMessage.scala 84.61% <66.66%> (-0.48%) ⬇️
...la/wvlet/airframe/http/finagle/FinagleServer.scala 72.52% <100.00%> (+0.30%) ⬆️
...n/scala/wvlet/airframe/http/grpc/GrpcContext.scala 100.00% <100.00%> (ø)
...n/scala/wvlet/airframe/http/grpc/GrpcService.scala 100.00% <100.00%> (+8.33%) ⬆️
...tp/grpc/internal/GrpcContextTrackInterceptor.scala 100.00% <100.00%> (ø)
...vm/src/main/scala/wvlet/airframe/http/Compat.scala 91.66% <100.00%> (+1.66%) ⬆️
...wvlet/airframe/http/internal/LocalRPCContext.scala 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7127ac2...db4d95a. Read the comment docs.

@xerial xerial requested a review from yuokada August 17, 2022 03:15
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

/**
* A dummy RPCContext
Copy link
Contributor

@yuokada yuokada Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a more better name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rename it to EmptyRPCContext

@xerial xerial merged commit 4f7ac2c into master Aug 17, 2022
@xerial xerial deleted the rpc-thread-local branch August 17, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

airframe-rpc: Add a common interface to access thread-local storage
2 participants