New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airframe-rpc: #2368 Add RPCContext to access thread-local storage and http request #2369
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2369 +/- ##
=======================================
Coverage 82.71% 82.72%
=======================================
Files 344 347 +3
Lines 13128 13154 +26
Branches 826 838 +12
=======================================
+ Hits 10859 10881 +22
- Misses 2269 2273 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
|
||
/** | ||
* A dummy RPCContext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give a more better name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename it to EmptyRPCContext
Closes #2368