Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround: Surface.of[A] throws InternalError on REPL #308

Merged
merged 2 commits into from Nov 12, 2018

Conversation

xerial
Copy link
Member

@xerial xerial commented Nov 12, 2018

No description provided.

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #308 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   82.71%   82.69%   -0.02%     
==========================================
  Files         153      153              
  Lines        5593     5595       +2     
  Branches      561      544      -17     
==========================================
+ Hits         4626     4627       +1     
- Misses        967      968       +1
Impacted Files Coverage Δ
...c/main/scala/wvlet/airframe/surface/Surfaces.scala 67.74% <75%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf505b...5ca628c. Read the comment docs.

@xerial xerial merged commit 1be3796 into wvlet:master Nov 12, 2018
@xerial xerial deleted the REPL-fix branch November 12, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant