New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name conversion functionallity to CName #360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=========================================
- Coverage 83.07% 0% -83.08%
=========================================
Files 156 56 -100
Lines 6010 108 -5902
Branches 595 8 -587
=========================================
- Hits 4993 0 -4993
+ Misses 1017 108 -909
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 83.07% 83.09% +0.01%
==========================================
Files 156 156
Lines 6010 6011 +1
Branches 595 575 -20
==========================================
+ Hits 4993 4995 +2
+ Misses 1017 1016 -1
Continue to review full report at Codecov.
|
88eefdb
to
8bb207a
Compare
a57f733
to
1937f22
Compare
@takezoe I think we should use a regular HashMap for Scala.js. For example by adding Compat.newWeakHashMap = ... |
@xerial Got it. Thanks for your advise! |
ea7fefc
to
73c93d2
Compare
ok. LGTM. It’s OK to merge this by yourself as a committer :) |
return
CName#equals()
HashMap
instead ofWeakHashMap
in Scala.jssnakeCase
dashCase
upperCamelCase
lowerCamelCase