Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenient methods to convert JSON <-> Scala object #519

Merged
merged 1 commit into from Jun 18, 2019
Merged

Add convenient methods to convert JSON <-> Scala object #519

merged 1 commit into from Jun 18, 2019

Conversation

xerial
Copy link
Member

@xerial xerial commented Jun 18, 2019

Move to/fromJson to MessageCodecFactory to use custom codecs

@xerial xerial mentioned this pull request Jun 18, 2019
Closed
@codecov
Copy link

codecov bot commented Jun 18, 2019 •
edited

Codecov Report

Merging #519 into master will increase coverage by 0.02%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   83.74%   83.77%   +0.02%     
==========================================
  Files         214      214              
  Lines        7968     7981      +13     
  Branches      590      597       +7     
==========================================
+ Hits         6673     6686      +13     
  Misses       1295     1295
Impacted Files Coverage Δ
...ala/wvlet/airframe/codec/MessageCodecFactory.scala 94.28% <100%> (+0.73%) ⬆️
...main/scala/wvlet/airframe/codec/MessageCodec.scala 82.97% <91.66%> (+1.39%) ⬆️
...in/scala/wvlet/airframe/codec/PrimitiveCodec.scala 86.09% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fcf3f...1513324. Read the comment docs.

@xerial xerial force-pushed the takezoe-convenient-json-methods branch from 77ca5f1 to 07d0619 Compare June 18, 2019 23:07
@takezoe @xerial
airframe-codec: Add convenient methods to convert JSON <-> Scala object
1513324 
Move to/fromJson to MessageCodecFactory to use custom codecs

Add fromJson: A for compatibility

Remove unused imports
@xerial xerial force-pushed the takezoe-convenient-json-methods branch from 07d0619 to 1513324 Compare June 18, 2019 23:15
@xerial xerial merged commit 0c6bd55 into wvlet:master Jun 18, 2019
@xerial
Copy link
Member Author

xerial commented Jun 18, 2019

@takezoe Moved the implementation to the MessageCodecFactory side to use custom codecs.

@xerial xerial deleted the takezoe-convenient-json-methods branch June 18, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xerial @takezoe