Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the internal routing code to wvlet.airframe.http.router package #824

Merged
merged 2 commits into from Nov 23, 2019

Conversation

xerial
Copy link
Member

@xerial xerial commented Nov 23, 2019

This PR is just for moving internal code to router package. Router object, which is used for defining HTTP endpoints will remain in http package, so it should have no user-facing change.

@xerial xerial merged commit 58cbb90 into wvlet:master Nov 23, 2019
@xerial xerial deleted the router-refactor branch November 23, 2019 00:55
@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #824 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         224      224           
  Lines        8904     8904           
  Branches      620      614    -6     
=======================================
  Hits         7208     7208           
  Misses       1696     1696
Impacted Files Coverage Δ
...la/wvlet/airframe/http/finagle/FinagleClient.scala 89.53% <ø> (ø) ⬆️
...la/wvlet/airframe/http/finagle/FinagleFilter.scala 100% <ø> (ø) ⬆️
...n/scala/wvlet/airframe/http/router/Automaton.scala 78.57% <ø> (ø)
...wvlet/airframe/http/router/HttpResponseCodec.scala 54.54% <ø> (ø)
...t/airframe/http/router/HttpRequestDispatcher.scala 95.23% <ø> (ø)
.../main/scala/wvlet/airframe/http/router/Route.scala 68.75% <ø> (ø)
...la/wvlet/airframe/http/finagle/FinagleServer.scala 67.56% <ø> (ø) ⬆️
...airframe/http/finagle/FinagleResponseHandler.scala 82.25% <ø> (ø) ⬆️
...tp/src/main/scala/wvlet/airframe/http/Router.scala 65% <ø> (ø) ⬆️
...wvlet/airframe/http/router/HttpRequestMapper.scala 96.66% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8eb636...2aabbec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant