Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple React Instances #101

Open
firzok opened this issue Mar 4, 2020 · 4 comments
Open

Multiple React Instances #101

firzok opened this issue Mar 4, 2020 · 4 comments

Comments

@firzok
Copy link

firzok commented Mar 4, 2020

I think that React and React Dom should be in Peer Dependencies rather than Dependencies in package.json
Because of this, npm ls react shows multiple instances of react when react-js-pagination is being used.

P.S: This is my first issue so please bear with me.

@iron66
Copy link

iron66 commented Mar 17, 2020

I'm not sure but several React instances may cause troubles with react hooks

@firzok
Copy link
Author

firzok commented Mar 19, 2020

I'm not sure but several React instances may cause troubles with react hooks

Are you saying that the solution I suggested will cause this problem ?

@pnicolli
Copy link

pnicolli commented May 6, 2020

@firzok It's the current situation that may cause problems with react-hooks. Your suggestion is helpful and should be addressed imho. See https://reactjs.org/warnings/invalid-hook-call-warning.html

@HauresBogdan
Copy link

npm ls react
client@0.1.0 C:\Users\PC\Desktop\xxx\client
+-- react@17.0.1
-- react-js-pagination@3.0.3 -- react@16.14.0

https://reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants