Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release for 4.2.0 to remove attrdict module dependency wheel install failure #2325

Closed
junwoo091400 opened this issue Dec 28, 2022 · 5 comments

Comments

@junwoo091400
Copy link

Operating system: Ubuntu 22.04
wxPython version & source: PyPi
Python version & source: Python 3.10.6

Description of the problem:
As described in this issue very well: #2225, current install of wxpython version 4.2.0 (https://pypi.org/project/wxPython/4.2.0/) fails, due to missing dependency to attrdict module, imported here:

from attrdict import AttrDict

Proposed Solution
To me, it seems like cherry picking this commit: 2e9169e, to the 4.2.0 release (https://github.com/wxWidgets/Phoenix/releases/tag/wxPython-4.2.0), and doing a patch release would solve the problem.

Note
However, I am also wondering, since the dependency is needed in buildtools/config.py, wouldn't this dependency fit better in requirements/intall.txt, instead of devel.txt?

E.g. here: 2e9169e#diff-48561a6ac9f59b3b79790238a78d2c345125e61834588671ac55f3fdafe1cd58R24

@junwoo091400 junwoo091400 changed the title Release a patch for wxPython 4.2.0 to remove attrdict module dependency failure Patch release for 4.2.0 to remove attrdict module dependency wheel install failure Dec 28, 2022
@Himura2la
Copy link

Himura2la commented Jan 19, 2023

This issue affects me

image

@JacobHayes
Copy link

Even if you ensure attrdict is installed, it is not compatible with python 3.10+ as from collections import Mapping was moved to from collections.abc import Mapping.

@h00man
Copy link

h00man commented Mar 30, 2023

Broken here too. Tried uninstalling and installing attrdict. Same for attrdict3. Tried the '--use-pep517' option. I think next I will try a venv with an older python.

Here running Lubuntu 22.10, and Python 3.10.7

$ pip install wxpython
Collecting wxpython
Using cached wxPython-4.2.0.tar.gz (71.0 MB)
Preparing metadata (setup.py) ... done
Requirement already satisfied: pillow in /home/mike/my_py3_venv/lib/python3.10/site-packages (from wxpython) (9.4.0)
Requirement already satisfied: six in /home/mike/my_py3_venv/lib/python3.10/site-packages (from wxpython) (1.16.0)
Requirement already satisfied: numpy in /home/mike/my_py3_venv/lib/python3.10/site-packages (from wxpython) (1.24.2)
Installing collected packages: wxpython
DEPRECATION: wxpython is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at pypa/pip#8559
Running setup.py install for wxpython ... error
error: subprocess-exited-with-error

× Running setup.py install for wxpython did not run successfully.
│ exit code: 1
╰─> [145 lines of output]

----snip ---

@swt2c
Copy link
Collaborator

swt2c commented Mar 30, 2023

@h00man you snipped the relevant parts of the output. :( When I saw it earlier via email, your error had nothing to do with attrdict. Instead, you're missing some Linux package prerequisites needed to build wxPython. See https://github.com/wxWidgets/Phoenix#prerequisites.

@swt2c
Copy link
Collaborator

swt2c commented Jun 8, 2023

New release 4.2.1 has been made which removes attrdict as a requirement on Linux.

@swt2c swt2c closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants