AuiManager: Incorrect loading of minimized panes

[lindakarlovska]

Operating system:
Description: Ubuntu 22.04.1 LTS
Python 3.10.6 (main, Nov 14 2022, 16:10:14) [GCC 11.3.0]
wx.version: 4.2.0 gtk3 (phoenix) wxWidgets 3.2.0

Description of the problem:
When I minimized the pane and then save a perspective and load it again, the warning "A pane with the name '__notebook_0_min' already exists in the manager!" is displayed in the command line. This is a bit strange, however the main problem is that the minimized button for this pane is added to GUI. So that we have two minimized buttons (one related to the previously minimized pane and one related to the incorrectly added pane). The button added after loading does not work. The original button works for minimizing and maximizing as expected.

To reproduce:

1. Start AUI.py demo and minimize the bottom called "A Third Auto-NB Pane" (btw does not matter which pane is minimized, the problems occurs on every minimizable pane)
   

2. Create a perspective in Perspectives -> Frame perspectives -> Create perspective

3. Immediately load this perspective by Perspectives -> Frame perspectives -> choose the above-created perspective

4. Then this error occurs in CLI:

/home/linduska/.local/lib/python3.10/site-packages/wx/lib/agw/aui/framemanager.py:4546: UserWarning: A pane with the name '__notebook_0_min' already exists in the manager!
  warnings.warn("A pane with the name '%s' already exists in the manager!" % pane_info.name)

And the minimized button is added to the bottom (the right one). This button does not work.

Expected behavior: It should deal with the same name of the loaded pane and it should not add the new unfunctional button.

[tianzhuqiao]

I think the issue is in the way to handle the min pane generated when we minimize a pane (wx/lib/agw/aui/framemanager.py). Looks like it works "correctly" with the following change.

def SavePerspective(self):
        ...
        for pane in self._panes:
            if pane.name.endswith('_min'):
                # ignore the generated '_min' panes
                continue
            result += self.SavePaneInfo(pane) + "|"
         ...

def LoadPerspective(self, layout, update=True, restorecaption=False):
        input = layout

        # check layout string version
        #    'layout1' = wxAUI 0.9.0 - wxAUI 0.9.2
        #    'layout2' = wxAUI 0.9.2 (wxWidgets 2.8)
        index = input.find("|")
        part = input[0:index].strip()
        input = input[index + 1:]

        if part != "layout2":
            return False
        
        # delete all the generated 'min' pane
        for pane in self._panes:
            if pane.name.endswith('_min'):
                self.RestoreMinimizedPane(pane)
        ...

[lindakarlovska]

Thanks @tianzhuqiao for analyzing it! Could you create the fixing PR so that it will be fixed in the next wxPython version?