New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cookies Support (wxGTK ) #14528
Comments
2012-07-27 11:03:38: @PBfordev commentedI know nothing about webview or GTK, but out of curiosity I peeked at the patch, surprised at its size of 92 kB. Are you sure you've submitted the correct patch file? It seems there's included a lot of changes in various unrelated files, perhaps these should be removed. Maybe you should also get rid of the differences which are there because only of whitespace changes, these make reviewing new code unnecessarily more difficult - I remember Vadim "scolding me" for that when I submitted my first patch. I believe SVN has an option for ignoring whitespace changes, but I've never used it so I am not sure how reliable it is. I hope you take no offense in my comments, I'm just trying to help. :) |
2012-07-27 11:24:53: evstevemd (Stefano) commentedThanks for your comment PB. I take it positively! Here is what I did to make the patch cd wxWidgets svn diff >wxwebview_cookies.patch ./misc/scripts/clean_patch wxwebview_cookies.patch >wxwebview_cookies_clean.patch [[BR]][[BR]]This is supposed to make patch clean by removing unnecessary files according to wxBlog. I suspect code beautification I use with my IDE cause addition of new lines/whitespaces Can you suggest what I can do? |
2012-07-27 11:52:13: @vadz changed status from new to infoneeded_new2012-07-27 11:52:13: @vadz commentedThe patch is definitely impossible to review or apply in the current state :-( I don't know what happened with the "$Id$" lines, but this, at least, could be filtered out easily with For now I'd recommend that you:
Thanks! |
2012-07-27 11:58:21: evstevemd (Stefano) commentedThanks vadim, I'll do that! |
2012-07-27 16:17:03: evstevemd (Stefano) commentedSo I did clean svn checkout and applied changes and here is clean patch If anything missing please point it out and I will work it out. 2012-07-27 16:17:03: evstevemd (Stefano) changed status from infoneeded_new to new |
2012-07-27 17:28:53: @lanurmi commentedThere are still a number of whitespace-only changes and wrong indentation in the patch. Use a tool such as |
2012-07-29 15:47:02: evstevemd (Stefano) commentedCan you explain to me what is missing? I have used meld to make the patch. I'm not maverick at meld and so can you point me to tutorial or something like directions? Thanks! |
2012-07-29 16:31:54: @vadz changed status from new to infoneeded_new2012-07-29 16:31:54: @vadz commentedI don't know how to use meld for this but typically you'd open a 2 side diff view and undo the changes consisting of white space only. As for the wrong indent, there is no magic solution, you need to reindent your code to use 4 space indentation manually. Finally, I don't understand if Also, a couple of small remarks about the changes themselves:
Other than that, I can't say much because the latest patch doesn't include the new files... |
2012-07-29 21:28:37: evstevemd (Stefano) commentedHi Vadim, thanks for comments. I think I have to learn more how can meld undo whitespace changes. Yes, I added
|
2012-07-29 21:34:45: @vadz commentedAdding The rest of the points:
As for making the patch: your patch is perfectly correct from patch submission point of view, the problem is just with the (unnecessary) whitespace changes you had made in the first place :-( Anyhow, it's not a huge deal, if you just look at the patch in Trac UI you can see which changes are unnecessary and simply revert them in your local copy and then redo the patch. Please review the patch file before submitting it to ensure it doesn't have any unnecessary changes. Thanks in advance and good luck! |
2012-08-15 17:49:14: evstevemd (Stefano) commentedHi Vadim and team, some commitments interrupted me and I had no way to get into a patch. I will work on patch in these few days and re-submit it. After that I will start the download part before I try to add same support in windows port regards, Stefano |
2012-09-12 12:56:35: evstevemd (Stefano) changed status from infoneeded_new to new |
2012-09-12 13:50:12: evstevemd (Stefano) uploaded file
|
2012-09-16 17:09:58: @sjlamerton changed status from new to infoneeded_new2012-09-16 17:09:58: @sjlamerton commentedThanks for the patch, but I'm afraid it doesn't apply for me, I get an error at line 101. I will extract the progress parts and implement them for other platforms as well. If I can I'll try and extract the cookie parts as well but if you could submit a working patch with only the cookie parts that would be great. |
2012-09-18 11:49:16: evstevemd (Stefano) uploaded file
|
2012-09-18 11:50:53: evstevemd (Stefano) changed status from infoneeded_new to new2012-09-18 11:50:53: evstevemd (Stefano) commentedI hope this one will be working but with both progress and cookies. |
2012-09-26 17:25:38: @sjlamerton commentedI have extracted the progress event stuff into a separate patch with some changes in #14699 |
2012-10-01 11:15:36: evstevemd (Stefano) commentedSo what about the cookies? I wanted to finish them so I can do something with download. If that be hard, can I send you zipped files (only those with changes) that compiles with latest SVN trunk? |
2012-10-01 17:52:38: @sjlamerton changed status from new to confirmed2012-10-01 17:52:38: @sjlamerton commentedAlthough the patch still doesn't apply cleanly for me (the trac preview not working is a good indication of this) I'll try and clean it up tonight and post my changes back here so you can check if they seem reasonable. I was also looking at adding OSX support, it looks like we can implement most of the API using NSHTTPCookieStorage and NSHTTPCookit. However as with Windows (as far as I know) we can only access the global cookie jar and not create our own local one so the API might need some small adjustments. I'll try and incorperate them into my changes. |
2012-10-01 23:22:23: @sjlamerton changed status from confirmed to infoneeded_new2012-10-01 23:22:23: @sjlamerton commentedI have attached an updated version of the patch, note I haven't tried compiling it yet as I have some most questions about the actual patch itself. I have made the following changes:
I still have a few questions though:
I will try and figure these out when I do further testing tomorrow but if you already know any of the answers that would be great! We will also need to change the API slightly for backends that don't support creating new cookie jars but do allow accessing the existing one as I mentioned above. |
2012-10-01 23:22:53: @sjlamerton uploaded file
|
2012-10-02 22:08:45: @sjlamerton uploaded file
|
2012-10-03 10:15:44: @vadz changed status from infoneeded_new to new2012-10-03 10:15:44: @vadz commentedReplying to [comment:18 steve_lamerton]:
Notice that there are still a few occurrences of the latter remaining in Some other minor stylistic comments:
You seem to have removed it in the latest version of the patch, so I guess this is not relevant any more, but FWIW I definitely think CWD should never be changed implicitly.
We probably need some way of determining whether this functionality is available. Traditionally, we just define |
2012-10-03 10:47:33: evstevemd (Stefano) commentedReplying to [comment:18 steve_lamerton]:
I'm checking out fresh SVN so that I can Apply the patch and move on :)
That is what I can say AFAIK
|
2012-10-03 11:12:04: @sjlamerton commentedReplying to [comment:19 vadz]:
Yes, I had to put them back, it didn't work.
I'll sort all these out, the patch I attached is very much still a work in progress!
Probably HasSetableCookieCar or CanSetCookieJar or something similar, better name suggestions welcome! |
2012-10-03 11:15:31: @sjlamerton commentedReplying to [comment:20 evstevemd]:
Thanks for your answers, I made most of the changes already in my more up to date patch but was slightly worried I might have broken something and not realised it! |
2012-10-03 11:17:49: @vadz commentedReplying to [comment:21 steve_lamerton]:
Err, how so?
I'm not sure here... |
2012-10-03 11:29:24: evstevemd (Stefano) commentedReplying to [comment:17 steve_lamerton]:
I have no Mac computer so a bit hard to say authoritatively But a good finding!
Since there is no creation of Jar here here are my suggestions
|
2012-10-03 11:35:54: evstevemd (Stefano) commentedReplying to [comment:23 vadz]:
I don't think this is consistent either. My reasons being this: |
2012-10-03 17:50:24: @sjlamerton commentedReplying to [comment:23 vadz]:
Please ignore my comment here, I have no idea why this didn't work last night, presumably a typo. Replying to [comment:25 evstevemd]:
I think the problem is that under OSX and MSW the backend always has its own global cookie jar, we cannot choose not to have it. As such we cannot set the cookie jar on those platforms. So I was thinking of an API similar to:
At that point we then know that we have a valid cookie jar and can access it as normal with GetCookieJar(). |
2012-10-04 11:27:34: @sjlamerton uploaded file
|
2012-10-04 11:29:15: @sjlamerton commentedI have made the various mentioned improvements and uploaded a new revision of the patch. The names of the cookie jar files should probably be changes but otherwise it is nearly there. |
2012-10-04 12:19:28: evstevemd (Stefano) commentedReplying to [comment:26 steve_lamerton]: [comment:25 evstevemd]:
I see. That will be nice but needs a "good" documentation to avoid confusion which I believe we can do! |
2012-11-25 23:56:50: @vadz commentedI don't think this is 2.9.5-critical. |
Issue migrated from trac ticket # 14528
component: WebView | priority: normal | keywords: cookies-support
2012-07-27 09:29:54: evstevemd (Stefano) created the issue
Here is a patch to add cookies support for cookies support. This patch adds only for wxGTK and I plan to add same for IE (MSW). Features includes
Basically this adds persistence to Webview for GTK.
Since this is my first contribution I would accept constructive criticism in coding style and any other mis-done/unstandard thing
Long live wxWidgets!
The text was updated successfully, but these errors were encountered: