wxrc: GetInternalFileName: Call to Printf: Format string arg is now constant.
#24547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow constant.
In the original code:
```
s.Printf(wxFileNameFromPath(parOutput) + wxT("$%03i-") + name2, i);
```
if `wxFileNameFromPath(parOutput2)` or `name2` had contained `'%'` (format specifiers),
the results would have been bad.
These strings are now given as additional arguments to `Printf`
(corresponding to `"%s"` format specifiers),
and the format string argument itself is now constant.
|
Applying as well, thanks! |
|
You are most welcome, thank you for this and for all your work !! 🌈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code:
if
wxFileNameFromPath(parOutput2)orname2had contained'%'(format specifiers), the results would have been bad.These strings are now given as additional arguments to
Printf(corresponding to"%s"format specifiers),and the format string argument itself is now constant.
This is a replacement of 9a5d32d as per #24437 (comment).