Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk hashes change when building from sources ZIP for Firefox Review #377

Closed
aklinker1 opened this issue Jan 27, 2024 · 4 comments · Fixed by #378
Closed

Chunk hashes change when building from sources ZIP for Firefox Review #377

aklinker1 opened this issue Jan 27, 2024 · 4 comments · Fixed by #378
Labels
bug Something isn't working

Comments

@aklinker1
Copy link
Collaborator

See #373
@aklinker1 aklinker1 added the bug Something isn't working label Jan 27, 2024
@dvlden
Copy link
Contributor

dvlden commented Jan 27, 2024

Small repo with steps in README:
Repro

@dvlden
Copy link
Contributor

dvlden commented Jan 27, 2024

And it seems that it doesn't just change letters for variables and functions.
Left is original and Right is after unzip & build:

Screenshot 2024-01-27 at 23 00 47

@dvlden
Copy link
Contributor

dvlden commented Jan 27, 2024

Of course... Because zipped version does not have .env file inside.

@dvlden dvlden mentioned this issue Jan 27, 2024
Merged
@aklinker1
Copy link
Collaborator Author

Released in v0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(zip)!: add includeSources and rename ignoredSources to excludeSources
2 participants
@dvlden @aklinker1