Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify calculatePosition and add option border #43

Closed
wants to merge 1 commit into from
Closed

modify calculatePosition and add option border #43

wants to merge 1 commit into from

Conversation

eugenejeonme
Copy link
Contributor

  1. Modify calculatePosition function for isInsideSafeAreaInsets and inViewController.
  2. Add option, border for messageView

Please check this! :)
And happy for your day.

1. Modify calculatePosition function for isInsideSafeAreaInsets and inViewController.
2. Add option, border for messageView
@wxxsw
Copy link
Owner

wxxsw commented Apr 18, 2019

Thank you. But it seems that this commit will break the behavior of the navigation bar when it is hidden or transparent (the message view extends to the top or bottom)

@eugenejeonme
Copy link
Contributor Author

You mean, the navigation bar was hidden programmatically. Right?
Like this, "navigationController?.isNavigationBarHidden = true".

Or, can i test that case?

My apps use the navigation controller, and It works normally.

@eugenejeonme
Copy link
Contributor Author

Oh! I see.
I re-build demo-app and try test that. :)

@wxxsw
Copy link
Owner

wxxsw commented Apr 18, 2019

You can compare your Fork version of Demo with the Demo in master.

In the Demo, click the "Toggle NavBar Translucent" or "Toggle NavBar Hidden" button, then click on Show Message and you will see the difference.

@eugenejeonme
Copy link
Contributor Author

Thanks, and i will modify! :)
so this close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants