Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why lambda_min not used in Backward? #2

Closed
luoyetx opened this issue Jan 8, 2017 · 4 comments
Closed

Why lambda_min not used in Backward? #2

luoyetx opened this issue Jan 8, 2017 · 4 comments

Comments

@luoyetx
Copy link

luoyetx commented Jan 8, 2017

As the title described. In forward part, lambda won't be smaller than lambda_min, but in backward part, it doesn't compare with lambda_min. Is there a reason to do so or just a mistake ?

@wy1iu
Copy link
Owner

wy1iu commented Jan 16, 2017

There is no need to compare lambda in back prop. If lambda reaches lambda_min, it will stay unchanged during the rest of the optimization.

@wy1iu wy1iu closed this as completed Jan 17, 2017
@luoyetx
Copy link
Author

luoyetx commented Jan 17, 2017

then, I think this line and this line won't promise. Since iter_ is always increased by 1 during forward, lambda will be smaller than lambda_min. Right?

@wy1iu
Copy link
Owner

wy1iu commented Jan 23, 2017

Yes, you are right about this. My apologies. It seems like I commit an old version of my code. Without lambda_min, it is okay for MNIST and CIFAR10, which is the reason I did not find out this mistake. But in the implementation for LFW and CIFAR100, these lines has been deleted. You will need lambda_min to reproduce performance in LFW and CIFAR100. Really sorry about that. I will fix this bug now.

@wy1iu
Copy link
Owner

wy1iu commented Jan 23, 2017

Thanks very much for reporting the bug. Really appreciate it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants