-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why lambda_min not used in Backward? #2
Comments
There is no need to compare lambda in back prop. If lambda reaches lambda_min, it will stay unchanged during the rest of the optimization. |
Yes, you are right about this. My apologies. It seems like I commit an old version of my code. Without lambda_min, it is okay for MNIST and CIFAR10, which is the reason I did not find out this mistake. But in the implementation for LFW and CIFAR100, these lines has been deleted. You will need lambda_min to reproduce performance in LFW and CIFAR100. Really sorry about that. I will fix this bug now. |
Thanks very much for reporting the bug. Really appreciate it. :) |
As the title described. In forward part, lambda won't be smaller than lambda_min, but in backward part, it doesn't compare with lambda_min. Is there a reason to do so or just a mistake ?
The text was updated successfully, but these errors were encountered: