Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes do not display icons correctly #3

Closed
4yx opened this issue Dec 26, 2018 · 3 comments · Fixed by #4
Closed

Themes do not display icons correctly #3

4yx opened this issue Dec 26, 2018 · 3 comments · Fixed by #4
Assignees
@4yx
Labels
bug Something isn't working. complete This is considered complete.

Comments

@4yx
Copy link
Member

4yx commented Dec 26, 2018 •
edited
Loading

Some themes like Dark and Lite are not displaying icons correctly and are missing some icons like the "Closed Support Tickets" one.
These are the only themes I have tested, we need to check the behaviour of other themes too.
@4yx 4yx added the bug Something isn't working. label Dec 26, 2018
@4yx 4yx self-assigned this Dec 26, 2018
4yx added a commit that referenced this issue Dec 26, 2018
@4yx
Major Theme Patch
b37ac3e 
Fixes #3 issue
@zero-arc
Copy link
Collaborator

OK,
I'll be checking on it! BTW I do need MoFH credentials to do this cuz I shutdown mine tho.

@4yx
Copy link
Member Author

4yx commented Dec 26, 2018

No need actually, my friend, as I have already set up a testing branch. I created this PR as a reference only.

BTW do not merge now, I have still some changes to do tomorrow.

@zero-arc
Copy link
Collaborator

Haha OK, my friend.

4yx added a commit that referenced this issue Dec 27, 2018
@4yx
Major Theme Patch
78bfdd8 
The actual patch, the previous one was the minor. Fixes #3
@4yx 4yx mentioned this issue Dec 27, 2018
Merged
@4yx 4yx closed this as completed in #4 Dec 27, 2018
4yx added a commit that referenced this issue Dec 27, 2018
@4yx
Major Theme Patch (#4)
640d894 
* Major Theme Patch

Fixes #3 issue

* Delete readme.md

Outdated

* Major Theme Patch

The actual patch, the previous one was the minor. Fixes #3

* Add Creative Commons License
@aa22dev aa22dev added the complete This is considered complete. label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4yx 4yx

Labels
bug Something isn't working. complete This is considered complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major Theme Patch WybeNetwork/VistaPanel-Themes
3 participants
@4yx @aa22dev @zero-arc