Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while building with latest angular and mapbox #16

Closed
paullryan opened this issue Jan 16, 2018 · 5 comments
Closed

Error while building with latest angular and mapbox #16

paullryan opened this issue Jan 16, 2018 · 5 comments

Comments

@paullryan
Copy link
Contributor

The latest build seems to have an outdated GeoJSON implementation as I'm getting the following when building today:

ERROR in node_modules/ngx-mapbox-gl/src/app/lib/source/geojson/geojson-source.component.d.ts(6,22): error TS2420: Class 'GeoJSONSourceComponent' incorrectly implements interface 'GeoJSONSourceOptions'.
  Types of property 'data' are incompatible.
    Type 'string | Feature<GeometryObject, { [name: string]: any; }> | FeatureCollection<GeometryObject, { ...' is not assignable to type 'string | Feature<GeoJSONGeometry, { [name: string]: any; }> | FeatureCollection<GeoJSONGeometry, ...'.
      Type 'Feature<GeometryObject, { [name: string]: any; }>' is not assignable to type 'string | Feature<GeoJSONGeometry, { [name: string]: any; }> | FeatureCollection<GeoJSONGeometry, ...'.
        Type 'Feature<GeometryObject, { [name: string]: any; }>' is not assignable to type 'Feature<GeoJSONGeometry, { [name: string]: any; }>'.
          Type 'GeometryObject' is not assignable to type 'GeoJSONGeometry'.
            Type 'GeometryObject' is not assignable to type 'GeometryCollection'.
              Types of property 'type' are incompatible.
                Type 'GeoJsonGeometryTypes' is not assignable to type '"GeometryCollection"'.
                  Type '"Point"' is not assignable to type '"GeometryCollection"'.

I'm working on a PR to fix this.

@Wykks
Copy link
Owner

Wykks commented Jan 16, 2018

Should be fixed by #14 :)

@Wykks Wykks closed this as completed Jan 16, 2018
@paullryan
Copy link
Contributor Author

Hrm, beat me to to it by a few minutes... trying with it now thanks.

@paullryan
Copy link
Contributor Author

Yep fixed.

@paullryan
Copy link
Contributor Author

@Wykks any thoughts about releasing a 1.0.0-beta.4?

@Wykks
Copy link
Owner

Wykks commented Jan 16, 2018

Probably tomorrow. I want to change a bit the cluster component before releasing beta4.

edit: actually cluster is good enough like that, I can add stuff later. beta4 released (as beta5, because npm..)! (and hopefully the last beta)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants