Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientboundBossEventPacketAccessor is not registered in mixin configs #125

Closed
kristofbolyai opened this issue Jul 1, 2022 · 5 comments · Fixed by #126
Closed

ClientboundBossEventPacketAccessor is not registered in mixin configs #125

kristofbolyai opened this issue Jul 1, 2022 · 5 comments · Fixed by #126
Labels
bug Something isn't working

Comments

@kristofbolyai
Copy link
Member

ClientboundBossEventPacketAccessor, which is used in FixPacketBugsFeature is not registed in wynntils.mixins.json.

@magicus, as you wrote that feature, is there a reason is or was it just a mistake?

@kristofbolyai kristofbolyai added the bug Something isn't working label Jul 1, 2022
@magicus
Copy link
Member

magicus commented Jul 1, 2022

Just a mistake.

Is there some way we can verify automatically that all classes in the mixin package is properly registered?

(Apart from the obvious: test the feature! ;-))

@magicus
Copy link
Member

magicus commented Jul 1, 2022

That's probably why it has regressed lately. I was wondering about that...

@kristofbolyai
Copy link
Member Author

Just a mistake.

Is there some way we can verify automatically that all classes in the mixin package is properly registered?

(Apart from the obvious: test the feature! ;-))

Perhaps a custom spotless module, not sure if anyone wants to do that though.

@kristofbolyai
Copy link
Member Author

That's probably why it has regressed lately. I was wondering about that...

Let's thank loom for breaking again (that's how I discovered this). 😅

@kristofbolyai
Copy link
Member Author

Do you wanna fix this yourself or should I make a quick PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants