Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatManager wrong chat type #224

Closed
kristofbolyai opened this issue Aug 4, 2022 · 12 comments
Closed

ChatManager wrong chat type #224

kristofbolyai opened this issue Aug 4, 2022 · 12 comments
Assignees
Labels
All mod loaders bug Something isn't working confimed

Comments

@kristofbolyai
Copy link
Member

@magicus
image
[21:45:06] [Render thread/INFO] (Minecraft) [CHAT] BACKGROUND-PARTY: §r§8[§r§7VIP+§r§8] §r§7FancyFedora§r§8 has just logged in!

This breaks InfoMessageFilterFeature as expected.

@kristofbolyai
Copy link
Member Author

image

Shift clicking soul points, assigned different types, not sure if that is what you want.

@HighCrit
Copy link
Member

HighCrit commented Aug 5, 2022

image
What is the distinction between the messagetypes normal and system? As I expected bomb bells to be classified as system, but they're not.

@magicus
Copy link
Member

magicus commented Aug 5, 2022

Thanks for the reports, I'll look into them!

@magicus
Copy link
Member

magicus commented Aug 5, 2022

@HighCrit THe difference is if Wynncraft tags the chat packet as CHAT or SYSTEM. I don't know the reason for their choice, or if it has any practical difference. (They look the same to the user.) I assume this is a vanilla distinction that does not really apply to Wynncraft. But the difference is yet another clue for us to correctly differentiate between certain types of messages.

@magicus
Copy link
Member

magicus commented Aug 5, 2022

@kristofbolyai With different types, you mean SYSTEM/NORMAL? As I said to HighCrit above, that is basically just reporting what Wynncraft choose.

@magicus magicus self-assigned this Aug 5, 2022
@kristofbolyai
Copy link
Member Author

@kristofbolyai With different types, you mean SYSTEM/NORMAL? As I said to HighCrit above, that is basically just reporting what Wynncraft choose.

Yeah, it is fine them, except the issue description.

@kristofbolyai
Copy link
Member Author

image
I think this issue is related. Shown on joining game.

@kristofbolyai
Copy link
Member Author

(Only some text is filtered)

@magicus
Copy link
Member

magicus commented Aug 9, 2022

What do you mean? The general advertising done by Wynncraft is not filtered. This is due to two reasons:

  1. It's a lot of different messages, and hence a lot of additional filters, and
  2. I felt it was not really fair -- Wynncraft need their chance to do some advertising. (I might reconsider this point if the user has a paid rank, then they have contributed and know about the situation.)

@kristofbolyai
Copy link
Member Author

Ah, I see. Okay then.

@Incompleteusern
Copy link
Contributor

@HighCrit THe difference is if Wynncraft tags the chat packet as CHAT or SYSTEM. I don't know the reason for their choice, or if it has any practical difference. (They look the same to the user.) I assume this is a vanilla distinction that does not really apply to Wynncraft. But the difference is yet another clue for us to correctly differentiate between certain types of messages.

Late, but vanilla client allosw user to filter SYSTEM or something.

@Incompleteusern
Copy link
Contributor

This also should be fixed by #296, so closing until if it reappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
All mod loaders bug Something isn't working confimed
Projects
None yet
Development

No branches or pull requests

4 participants