Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the triangle percussion notes #108

Closed
FriendlyFloyd opened this issue Apr 3, 2022 · 4 comments
Closed

Combine the triangle percussion notes #108

FriendlyFloyd opened this issue Apr 3, 2022 · 4 comments
Assignees
Labels
improvement Improve something that already exists
Projects

Comments

@FriendlyFloyd
Copy link

Something I wanted to resolve since the first MIDIJam, I think it would make more sense to merge the "Triangle" and "Mute Triangle" into a single model, with the hand (or other dampener) appearing to mute the triangle, and either moving away or disappearing for the open note

@FriendlyFloyd FriendlyFloyd added the enhancement New feature or request label Apr 3, 2022
@wyskoj wyskoj added improvement Improve something that already exists and removed enhancement New feature or request labels Apr 3, 2022
@lickington
Copy link

Well then, combining the triangle notes would be a big problem, because if the open and mute triangles were playing at the same time, that would mean that there would be duplications.

@FriendlyFloyd
Copy link
Author

When would they play at the same time? Couldn't it work like the hi-hat?

@lickington
Copy link

I once listened to an MID file where both of them played at the same time, and only one of them showed up. Weird. 😕

@FriendlyFloyd
Copy link
Author

Like I said: it works on similar logic to hi-hat. There's actually a value that you can use to stop one MIDI note from playing when another is triggered (I think it's called "delta" something?), and that's how you can get the hi-hat and triangle to stop the "open" note once the "closed" note is played.

@wyskoj wyskoj self-assigned this Jun 28, 2022
@wyskoj wyskoj added this to To do in v1.7.0 Jun 28, 2022
@wyskoj wyskoj closed this as completed in 02f5f32 Jul 10, 2022
@wyskoj wyskoj moved this from To do to Done in v1.7.0 Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve something that already exists
Projects
No open projects
Development

No branches or pull requests

3 participants