Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global proxy with secondary order authentication #32

Open
cwgoes opened this issue Nov 17, 2020 · 2 comments
Open

Global proxy with secondary order authentication #32

cwgoes opened this issue Nov 17, 2020 · 2 comments

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Nov 17, 2020

Goal is to allow easy transferFrom usage without deployment of a second proxy.

  • Exchange contract requires known AuthenticatedProxy implementation for semantic correctness of proxy
    • Could add an extra, specially authorised, revised contract which has logic to check transferFrom signatures
    • Need to pass additional data to the proxy contract so that it can authenticate signatures
  • Alternative approach: make order maker a contract
    • Use the same proxy contract
    • isValidSignature-equivalent method checks signature on behalf of user
      • Basically checks that the user (looked up from call data) signed the Wyvern order
      • Is there an altered version of EIP 1271 that allows passing extra data?
    • Needs to pass call data as well so user can be looked up
    • Can choose to require additional signature (e.g. by relayer) or not
    • Users then approve proxy deployed by this contract
@cwgoes cwgoes self-assigned this Nov 17, 2020
@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 17, 2020

42b1e9ed-8a08-4796-981d-7a6dfd05c683

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 17, 2020

Supports interface for contract calls, first try special one, then try EIP 1271 one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant