Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The role of 'processed_mid' #19

Closed
JustinYuu opened this issue Sep 23, 2022 · 2 comments
Closed

The role of 'processed_mid' #19

JustinYuu opened this issue Sep 23, 2022 · 2 comments

Comments

@JustinYuu
Copy link

Hi,
The function midi_to_mp3 in src/midi2mp3.py includes a variable named 'processed_mid', which in my opinion converts the raw midi to the specified tempo in video2npz/metadate.json. However, the following fs.midi_to_audio function still picks the original midi_path instead of the processed_mid to generate the mp3 music, and I cannot find any usage of processed_mid in the following codes. Therefore, I wonder what is the role of the processed_mid, and if the variable in the fs.midi_to_audio should be processed_mid rather than midi_path.
Thanks

@JustinYuu
Copy link
Author

I think the variable in the midi_to_audio function should be processed_mid instead of midi_path just as the codes in CMT.ipynb are present.

@wzk1015
Copy link
Owner

wzk1015 commented Sep 28, 2022

Fixed by 4ab7d8f. Thanks for pointing out and sorry for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants