Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat pages with invalid title as nonexistent #48

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Conversation

@codecov-io
Copy link

codecov-io commented Jul 17, 2017

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   17.19%   17.19%           
=======================================
  Files          31       31           
  Lines        3699     3699           
=======================================
  Hits          636      636           
  Misses       3063     3063
Impacted Files Coverage Δ
src/AppBundle/Controller/ArticleInfoController.php 0% <0%> (ø) ⬆️
src/Xtools/Page.php 36.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5b56e...d0f8505. Read the comment docs.

Copy link
Member

@Matthewrbowker Matthewrbowker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MusikAnimal MusikAnimal merged commit b6b7583 into master Jul 17, 2017
@MusikAnimal MusikAnimal deleted the invalid-titles branch July 18, 2017 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants