Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set/force isTerminal to be true. #6

Closed
bbuck opened this issue Feb 27, 2017 · 2 comments
Closed

Option to set/force isTerminal to be true. #6

bbuck opened this issue Feb 27, 2017 · 2 comments

Comments

@bbuck
Copy link

bbuck commented Feb 27, 2017

I've wrapped the standard os.Stdout/os.Stderr io.Writer options, and also use io.MultiWriter for potentially multiple output targets. I do this because I have a layer of text processing to take place before output hits the terminal. With the latest updates to this library (and logrus) logging is now downgraded because io.Writer is not an *os.File but instead my custom wrapping type. Perhaps this is really an issue with logrus but it seems like it would be nice to force terminal status.

@bbuck
Copy link
Author

bbuck commented Feb 27, 2017

Disregard.

I posted an issue to add an interface that I can implement to determine if my custom type is a Terminal or not. This is definitely not something this formatter should worry about. Not only that, but my custom type no longer needs to do color processing, I can move that into hooks. But I still use io.MultiWriter and would want to implement (myself) whether or not to report if the multi-writer is a terminal or not.

@bbuck bbuck closed this as completed Feb 27, 2017
@x-cray
Copy link
Owner

x-cray commented Feb 27, 2017

=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants