Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typedefinition bug #38

Closed
ghost opened this issue May 15, 2019 · 1 comment
Closed

typedefinition bug #38

ghost opened this issue May 15, 2019 · 1 comment
Labels
bug

Comments

@ghost
Copy link

ghost commented May 15, 2019

In the type definition:
subscribeToStreamFrom(streamId: string, fromEventNumber: number, ...)

Should be:
subscribeToStreamFrom(streamId: string, fromEventNumber: number | null, ...)

It is missing the | null, for the fromEventNumber parameter. Without it, you cannot read from the beginning of the stream.
@x-cubed
Copy link
Owner

x-cubed commented May 19, 2019

Thanks for pointing that out, I've pushed a commit to resolve it

@x-cubed x-cubed added the bug label May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@x-cubed