Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghq fails to clone or list if files or directories in the GHQ_ROOT are not accessable #173

Closed
uberjay opened this issue May 13, 2019 · 2 comments · Fixed by #176
Closed

Comments

@uberjay
Copy link

uberjay commented May 13, 2019

This looks similar to #165, but instead of a dangling symlink, I have directories which are root owned. It's probably a little odd, but I have my GHQ_ROOT set to the root of a macOS volume. In there are several root owned directories (.Trashes, .Spotlight-V100 and .fseventsd).

In my opinion, skipping over inaccessible directories, or possibly directories starting with a dot would be a good idea. As is, after updating my ghq, no operations work anymore:

ghq get https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
     error open /Volumes/code/.Spotlight-V100: permission denied

After disabling spotlight indexing and removing that directory, the next one is .Trashes:

$ ghq list
     error failed to filter repos while walkLocalRepositories(repo): open /Volumes/code/.Trashes: permission denied
@Songmu
Copy link
Member

Songmu commented May 16, 2019

Thanks for reporting. I fixed at #176.

Instead of ignoring all dotfiles flatly, I made a check if it is a dotfile if there is no permission.

@Songmu
Copy link
Member

Songmu commented May 16, 2019

released as v0.12.3. please try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants