Fix z index of hamburger menu #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyronald
approved these changes
Nov 13, 2018
nicksp
approved these changes
Nov 13, 2018
Merged
nicksp
pushed a commit
that referenced
this pull request
Nov 13, 2018
* Fix z index of hamburger menu * Build app # Conflicts: # lib/auto-ui.js.map
nicksp
added a commit
that referenced
this pull request
Nov 14, 2018
* Add source maps to build lib (#271) * Include filter icon at SvgIcon component (#268) * Include filter icon at SvgIcon component * Include build * Build app * Allow attaching failed files again in Portfolio UI (#270) * Allow attaching failed files again in Portfolio UI Closes XP-2410 * Build app * Add UI support for a single SelectBox selection (#267) * Simplify Search Closes XP-2389 * Update snapshots and build lib * Fix `closeDropdown` prop in `SelectBox` The `closeDropdown` prop from the `SelectBox` component was designed so that it would only work when it was provided by a parent `Dropdown` component: ```js <Dropdown> <SelectBox closeDropdown /> </Dropdown> ``` However, when using it outside a `Dropdown` this has no effect on the `SelectBox`. This commit fixes the behavior by using the `closeDropdown` prop from the internal `Dropdown` component inside `SelectBox` when it isn't provided by any parent. * Update snapshots and build lib * Only close dropdown when boolean prop was set * Introduce example using prop `closeDropdown` * Add another case for component usage * Build app * Resize typography and spacings of components (#263) * Resize typography and spacings of components * Resize typography and spacings of components * Resize typography and spacings of components * Resize typography and spacings of components * Resize typography and spacings of components * Revert package-lock changes * Update font-size and spacing of SearchForm and ApplicantGrid and children components * Include snapshots and build * Build app * Updates for code review * Include build and update snapshots * Tweak some styles as per designs * Build app * Upgrade ApplicantGridHeader based on new design (#269) * Updates on tabular components * Updates for ApplicantBadge, ApplicantGrid and ApplicantGridHeader * Updates for ApplicantBadge, ApplicantGrid and ApplicantGridHeader * Updates for filtering on tabular view * Update docs * Fix flow issues * Updates for tabular filters * Includes forceUpdate at ApplicantGridHeader * Updates on ApplicantGridHeader and SearchForm * Update snapshots and include build * Change `isFiltering: boolean` to `isFilteringFn: () => boolean` This will simplify things over at `auto` * Examples + Build lib * Remove forceUpdate from sorting method * Pass `isFetching` prop to filter dropdown * Build lib + snapshots * Make font sizing consistent between different states * Build app * Fix can't set Rank for applicant (#272) * Fix can't set Rank for applicant Closes XP-2461 * SelectBox improvements * render correctly centered when placeholder is missing * autoclose dropdown after selecting Rank * Build app + snapshots * Remove useless prop * Build app * Fix z index of hamburger menu (#276) * Fix z index of hamburger menu * Build app * Fix render glitches for some search form fields (#277) * Fix glitches render for some search form fields * Update snapshots * Build app * Build app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Type: Fixes
Fixes https://x-team-internal.atlassian.net/browse/XP-2474
Description
The Hamburger menu from the top-right hides behind the "Show" button of the Search Form in tabular view
Checklist
Before submitting a pull request, please make sure the following is done:
In RevieworIn Progressdepending on its status)IN REVIEWcolumnnpm run lint)npm run flow).snap).snap) is changed or added accordinglyRelated PRs
N/A
Steps to Test or Reproduce
1- Go to the Admin page
2- Choose the tabular view
3- click in the hamburger menu
4- You should be able to see the hamburger menu.
Impacted Areas in Application
Admin page > Tabular view > Hamburger menu
Screenshots