Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Potential bug in example/handlers.py AuthHandler._on_signin(). #5

Closed
erichiggins opened this issue Sep 18, 2012 · 1 comment
Closed

Comments

@erichiggins
Copy link
Collaborator

The following snippet appends to auth_ids directly instead of using User.add_auth_id. Doing so prevents the creation of a new Unique instance to account for the additional auth_id.

u.auth_ids.append(auth_id)
u.populate(**_attrs)
u.put()

Here's another way:

u.populate(**_attrs)
u.add_auth_id(auth_id)

Note: add_auth_id makes a put() call.

@x1ddos
Copy link
Owner

x1ddos commented Sep 19, 2012

Eric, thanks again and I think I'm just going to add you to the committers :)

Closed by 919f0e6 though I don't have any tests for the example app. Maybe I should add some.

@x1ddos x1ddos closed this as completed Sep 19, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants