Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting the LTC volume #44

Closed
superbigio opened this issue Nov 8, 2019 · 4 comments
Closed

getting the LTC volume #44

superbigio opened this issue Nov 8, 2019 · 4 comments

Comments

@superbigio
Copy link

I would like to add support for getting the LTC volume in dBFS:
double ltc_encoder_get_volume(LTCEncoder *e)

@x42
Copy link
Owner

x42 commented Nov 9, 2019

Yeah why not.. might be handy to query the 8 bit equivalent.
Do you have a use-case in mind, or is this just for consistency?

@superbigio
Copy link
Author

superbigio commented Nov 9, 2019

Yes, I am wrapping your library into two Max/MSP externals. In Max/MSP terminology the volume is an attribute of the LTC so I need getters and setters for it. I think you have written Max/MSP externals in the past so you know what I mean. In any case being able to query the volume might be handy in a variety of situations. And of course it's also good for consistency in general. Being such a trivial function to write, why not?
Notice that the same could be said for the filter/risetime parameter. I could create a PR for both volume and filter if you want, but so far I haven't had the need to get the rise-time value.
Let me know what I should do.

@x42
Copy link
Owner

x42 commented Nov 9, 2019

I'd be happy to pull either.

For use in Max/MSP I'd not expose either, and just offer the smallest API that's required. Leaving fewer ways for users to shoot themselves in the foot.

@superbigio
Copy link
Author

Ok, I will include them both then. PR on its way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants