Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Error with Astro SSR adapters #45

Closed
Tanish2002 opened this issue Jun 27, 2023 · 7 comments
Closed

Build Error with Astro SSR adapters #45

Tanish2002 opened this issue Jun 27, 2023 · 7 comments

Comments

@Tanish2002
Copy link

Tanish2002 commented Jun 27, 2023

I'm trying deploy my project on cloudflare via the astro provided ssr adapter.

Whenever I try to build the project I get this error:

✘ [ERROR] No matching export in "node_modules/.pnpm/solid-js@1.7.7/node_modules/solid-js/web/dist/server.js" for import "memo"

    node_modules/.pnpm/solid-icons@1.0.8_solid-js@1.7.7/node_modules/solid-icons/lib/index.js:1:47:
      1 │ import { mergeProps, spread, insert, isServer, memo, template } from 'solid-js/web';
        ╵                                                ~~~~

✘ [ERROR] No matching export in "node_modules/.pnpm/solid-js@1.7.7/node_modules/solid-js/web/dist/server.js" for import "template"

    node_modules/.pnpm/solid-icons@1.0.8_solid-js@1.7.7/node_modules/solid-icons/lib/index.js:1:53:
      1 │ import { mergeProps, spread, insert, isServer, memo, template } from 'solid-js/web';
        ╵                                                      ~~~~~~~~

 error   No matching export in "node_modules/.pnpm/solid-js@1.7.7/node_modules/solid-js/web/dist/server.js" for import "memo"
  File:
    node_modules/.pnpm/solid-icons@1.0.8_solid-js@1.7.7/node_modules/solid-icons/lib/index.js:1:47
  Code:
    > 1 | import { mergeProps, spread, insert, isServer, memo, template } from 'solid-js/web';
        |                                               ^
      2 | import { splitProps } from 'solid-js';
      4 | const _tmpl$ = /*#__PURE__*/template(`<svg stroke-width="0"></svg>`, 2),

Out of curiosity I tried it with other adapters like vercel and the problem still persists.

It builds fine without any ssr adapters.

Here is a minimal reproduction of problem: https://codesandbox.io/p/sandbox/bold-wilbur-kch7zp
You can check it by doing a yarn build

@Guergeiro
Copy link

Having the same issue.

@x64Bits
Copy link
Owner

x64Bits commented Jul 20, 2023

Hi thanks for report this, I'm sure that this problem is related to exports in package.json generated by the library, I'm imitating the way solidjs did it in its 1.4 version, but I have seen that they added the worker key which I imagine should be used to target the correct import using cloudflare.

@Guergeiro
Copy link

@x64Bits I've tried to offload it in Astro using client:only="solid-js" directives and even just re exporting a the Svg as its separate Solid component, to no avail. Do you have a solution on the way for this?

@x64Bits x64Bits mentioned this issue Sep 20, 2023
@x64Bits
Copy link
Owner

x64Bits commented Sep 20, 2023

Hello, sorry for the delay, I have sent a beta version of the package with a possible correction for this problem, if you can take a look at it for feedback, there is also an open PR in case you have comments #54, greetings and thank you very much.
https://www.npmjs.com/package/solid-icons/v/1.1.0-beta.1

@silesmo
Copy link

silesmo commented Sep 25, 2023

The solid-icons@1.1.0-beta.1 still has the same issues @x64Bits

@x64Bits
Copy link
Owner

x64Bits commented Nov 1, 2023

Hi @silesmo, thanks for let me know about it, Version 1.1.0 address this issue, can you take a look it is working properly now?

@x64Bits
Copy link
Owner

x64Bits commented Nov 6, 2023

I'll assume this issue was resolved in 1.1.0, regards.

@x64Bits x64Bits closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants