-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute view box is missing since solid-js 1.6 #15
Comments
Is this the cause for the bug: solidjs/solid#1296? |
I also had this issue but even after downgrading SolidJS to |
downgrading to |
Hi everyone, if there seems to be a problem when destructuring the props, do you think it is convenient to establish a specific version of solid-js as a dependency for solid-icons? Because right now |
hi @x64Bits, Thanks for creating this for us :-) Feather icons has specific version but since solid changes every 3 months it's best to leave it as it is. We can just report the problem if people run into. Otherwise, you will need to update this constantly.... |
Will this be fixed? Downgrade cant be the solution? |
downgrading to |
I'm sending version 1.0.3 which adds solid-js <=1.5.7 as a dependency to avoid the problem, I did not want to have a direct dependency on solid since it was implicit but if is not added the library it breaks, If anyone has a better idea I'll leave this thread open for suggestions. |
@x64Bits with |
@outbackStack I understand, because I don't like the idea of forcing a version either, but it tells me that people will choose to downgrade |
@x64Bits I've seen packages where people don't maintain it anymore and we are all stuck even though the latest version still works. It's up to you on how much time you have to maintain this. I'm just thinking it will be easier for you without dependency requirement.... Anyhow, if it does not work with the latest version of Thanks again for creating this. |
We are waiting for solidjs to fix this problem! |
According to @ryansolid in solidjs/solid#1296 (comment). All spread issues should be fixed in 1.6.1. Unfortunately, the view box is still missing for all SVGs when using
|
Yes, I use |
Everything seems to indicate that the changes I made in 1.0.3 had no effect in general, mergeProps seems to help fix this, |
I can confirm that version 1.0.4 fixes this issue. @x64Bits Thank you very much for the bug fix! |
Bug:
When using solid-js 1.6.0, the attribute
viewBox
is missing for all SVGs.Workaround:
Downgrading solid-js to version 1.5.9 or earlier.
The text was updated successfully, but these errors were encountered: