This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
Fix API versioning #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve #17
mu-hun
commented
Nov 4, 2020
Comment on lines
+49
to
+64
| addCache(getCacheVersion(), API_URL) | ||
| ]) | ||
| ) | ||
| }) | ||
|
|
||
| self.addEventListener('fetch', evt => { | ||
| if (evt.request.url === API_URL) { | ||
| const currentAPI = getCacheVersion() | ||
| const cacheWhitelist = [CACHE_NAME, currentAPI] | ||
|
|
||
| evt.waitUntil( | ||
| caches.has(currentAPI).then(cache => { | ||
| if (!cache) { | ||
| return Promise.all([ | ||
| addCache(currentAPI, API_URL), | ||
| cleanOldCache(cacheWhitelist) |
There was a problem hiding this comment.
install 이벤트에서 초기 버전을 설정하고, fetch에서 버전을 갱신합니다.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install이벤트에서 초기 버전을 설정하고,fetch에서 버전을 갱신하는 걸로 해결했습니다.event.waitUntill내부의.catch프로미스 체인 제거프로미스 결과에 따라
event.waitUntill의 행동이 달라지는 것 같아 지웠습니다.ExtendableEvent.respondWith내부의 오류의 경우 서비스 워커 콘솔이나, 네트워크 패널에서 조사가 가능하므로 지웠습니다.둘다 예제를 그래로 가져오면서
console.log를 쓴 실수도 있었습니다. 😅