Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A way to save the posts before shredding them? #25

Closed
pteek opened this issue Mar 21, 2015 · 5 comments
Closed

A way to save the posts before shredding them? #25

pteek opened this issue Mar 21, 2015 · 5 comments
Labels
enhancement

Comments

@pteek
Copy link
Contributor

pteek commented Mar 21, 2015

So we can have a personal account of the history. Self-posts, links and comments.

This should be fairly easy to implement.
@pteek pteek changed the title A way to save the post before shredding them? A way to save the posts before shredding them? Mar 21, 2015
@x89
Copy link
Owner

x89 commented Mar 22, 2015

What format do you mean? At the moment I have a cron job that saves the output (when verbose = True) to a dated text file and that's sufficient for my use case.

Do you mean a single file? SQLite database?

@pteek
Copy link
Contributor Author

pteek commented Mar 23, 2015

I am working on a solution by serializing the json_dict as json in txt files. It's good enough for me.

pteek added a commit to pteek/Shreddit that referenced this issue Mar 23, 2015
@pteek
x89#25 Added json dump for submissions
2d2db60 
Defined get_sentence() on windows.
Changed utcnow to now because praw's utc time is actually in current
timezone. line 125
Removed u prefix from random string. line 167
@pteek
Copy link
Contributor Author

pteek commented Mar 23, 2015

Test please https://github.com/pteek/Shreddit/tree/dump

pteek added a commit to pteek/Shreddit that referenced this issue Mar 23, 2015
@pteek
x89#25 Check for element before del
78b6ba2
pteek added a commit to pteek/Shreddit that referenced this issue Mar 23, 2015
@pteek
x89#25 Added json dump for submissions
4814c30 
Changed utcnow to now because praw's utc time is actually in current
timezone. line 125
Removed u prefix from random string. line 167
pteek added a commit to pteek/Shreddit that referenced this issue Mar 23, 2015
@pteek
x89#25 Add dump config variable
64f0b79
pteek added a commit to pteek/Shreddit that referenced this issue Mar 23, 2015
@pteek
x89#25 Properly remove html from json
872d34f
@x89
Copy link
Owner

x89 commented Mar 23, 2015

It looks good on the surface. One thing though, the comment "Saving a copy" should only be printed if keep_a_copy is true (otherwise it's confusing to users that don't have it enabled, and as the primary aim of the program is deleting the user should be informed when it happens regardless.)

pteek added a commit to pteek/Shreddit that referenced this issue Mar 23, 2015
@pteek
x89#25 Added json dump for submissions
8bc863d 
Changed utcnow to now because praw's utc time is actually in current
timezone. line 125
Removed u prefix from random string. line 167
pteek added a commit to pteek/Shreddit that referenced this issue Mar 23, 2015
@pteek
x89#25 Fix a print
09cdcb4
@x89
Copy link
Owner

x89 commented Mar 25, 2015

Throw up a PR if you want me to check it over and incorporate it into here!

@x89 x89 closed this as completed Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@x89 @pteek