Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decode_time_units() to not run if time dimension does not exist #112

Closed
tomvothecoder opened this issue Oct 1, 2021 · 0 comments · Fixed by #113
Closed

Update decode_time_units() to not run if time dimension does not exist #112

tomvothecoder opened this issue Oct 1, 2021 · 0 comments · Fixed by #113
Assignees
Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Oct 1, 2021

Is your feature request related to a problem? If yes, Please describe

Some datasets may not have a time dimension, so decode_time_units() should not run.

Describe your proposed solution

if "time" in ds.dims:
    ds = decode_time_units(ds)

Describe alternatives solutions you've considered

N/A

Additional context

N/A

@tomvothecoder tomvothecoder added the type: enhancement New enhancement request label Oct 1, 2021
@tomvothecoder tomvothecoder self-assigned this Oct 4, 2021
@tomvothecoder tomvothecoder added Priority: High type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. and removed type: enhancement New enhancement request labels Oct 4, 2021
@tomvothecoder tomvothecoder added this to To do in v0.1.0 via automation Oct 4, 2021
@tomvothecoder tomvothecoder added this to the v1.0.0 milestone Oct 4, 2021
v0.1.0 automation moved this from To do to Done Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
No open projects
v0.1.0
  
Done
1 participant