Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Update _get_weights() method for SpatialAccessor and TemporalAccessor #251

Closed
tomvothecoder opened this issue Jun 6, 2022 · 0 comments · Fixed by #252
Closed

[Feature]: Update _get_weights() method for SpatialAccessor and TemporalAccessor #251

tomvothecoder opened this issue Jun 6, 2022 · 0 comments · Fixed by #252
Labels
type: enhancement New enhancement request
Projects
v0.3.0

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Jun 6, 2022 •
edited
Loading

Is your feature request related to a problem?

These methods are useful to have publicly so the user can reuse weights for other operations, or to see what the generated values are for validation purposes.

Related to this comment:

I think this issue can probably be closed since the weights can be retrieved via .get_weights() here. If a more complex implementation of this is needed in the future, that could probably be added as a feature request.
— @pochedls #114 (comment)

Describe the solution you'd like

  • Rename _get_weights() to get_weights()
  • Update references to the new name

Describe alternatives you've considered

No response

Additional context

No response
@tomvothecoder tomvothecoder added the type: enhancement New enhancement request label Jun 6, 2022
@tomvothecoder tomvothecoder added this to To do in v0.3.0 via automation Jun 6, 2022
This was referenced Jun 6, 2022
Closed
Merged
@tomvothecoder tomvothecoder moved this from To do to In progress in v0.3.0 Jun 8, 2022
@tomvothecoder tomvothecoder changed the title [Feature]: Make SpatialAccessor._get_weights() and TemporalAccessor._get_weights() public [Feature]: Update _get_weights() method for SpatialAccessor and TemporalAccessor Jun 15, 2022
v0.3.0 automation moved this from In progress to Done Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New enhancement request
Projects
No open projects
v0.3.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update _get_weights() method for SpatialAccessor and TemporalAccessor xCDAT/xcdat
1 participant
@tomvothecoder