Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused code doesn't grey out #1

Open
bradyhanna opened this issue Jan 22, 2019 · 0 comments
Open

Unused code doesn't grey out #1

bradyhanna opened this issue Jan 22, 2019 · 0 comments

Comments

@bradyhanna
Copy link

bradyhanna commented Jan 22, 2019

Hi there,

Really like the theme! Recently I have realized that the unused code/imports are not being greyed out. I have researched it a bit and it seems that this is due to the configuration options naming being changed.

It seems that it used to use a 6 digit RGB value, but now uses an 8 digit RGBA which seems to ignore the RGB portion and only uses the alpha to determine the opacity. See this and search for editorUnnecessaryCode.opacity

I have been using the following override to manually set the opacity to 50%:

"workbench.colorCustomizations": {
    "editorUnnecessaryCode.opacity": "#00000080"
}

Without above opacity

screen shot 2019-01-23 at 10 06 22 am

With above opacity

note the import statement

screen shot 2019-01-23 at 10 05 54 am

Would be awesome to get this fix into the theme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant