Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Effects #3661

Closed
Strawberry1997 opened this issue Jan 1, 2023 · 9 comments
Closed

Copy Effects #3661

Strawberry1997 opened this issue Jan 1, 2023 · 9 comments

Comments

@Strawberry1997
Copy link

Is your feature request related to a problem? Please describe.
copying a line of effects is cumbersome because you have to make timing marks for the whole sequence.

*Describe the solution you'd like
Screenshot 2022-12-31 at 8 42 04 PM

I would like to click on the prop in the timeline and it will automatically select all the effects on that layer.
also be able to select more than one layer at a time by using the ctrl key and or dragging a box around the layers to be selected.
once they are selected ctrl-c can be used, then to paste you would select on another prop/layer and ctlr-v to paste correctly in the timeline.
This feature is in Vixen.

@AzGilrock
Copy link
Collaborator

No you don’t need timing marks to do a copy. In fact it’s easiest to turn off all timing tracks and then drag a yellow dashed box around what you want to copy. You can also right-click a layer and select all the effects on that row or you can select all effects on the entire model. Now learn xLights so you can go tell the Vixen guys the 5,000 things we can do that it can’t

@Strawberry1997
Copy link
Author

I drew a yellow box around a group of effects and copied, then selected a new row to copy them to but it didn't keep them in the same timeframe.

@Strawberry1997
Copy link
Author

Screenshot 2023-01-01 at 2 37 21 PM

@Strawberry1997
Copy link
Author

For the whole Layer or Line
Screenshot 2023-01-01 at 2 37 32 PM

@AzGilrock
Copy link
Collaborator

Yes when you select effects they are not locked into the time where they came from. It’s meant to be able to paste anywhere. The first effect on the top row of your selection sets the reference. Then when you right click to paste that click defines where the reference will start for the paste. It’s assumed if you want the whole row you will do a row copy. But there are other tricks I use if you have trouble getting the alignment you want. Put a dummy effect at the start of the top row. Then you can paste it without being precise, then select everything you pasted and hold down shift to drag it all left till it hits time zero then it will be aligned how it was where you copied it.

@Strawberry1997
Copy link
Author

I agree paste anywhere, but I would like a feature to select a prop and it lock it to the timeline.

@devinhedge
Copy link

It seems that the requested featur is partially implemented but might have a bug in it.

I noticed last night, while working on next year's sequences, that when I select effects on multiple layers or select all of the effects on a model that have multiple layers, when I attempt to paste them in a different instance of xLights, it only pastes one effect, or doesn't paste as all.

This is actually two different behaviors it seems.

Behavior one:

  1. Turn off timing marks.
  2. Select effects on multiple layers in a section for a model by dragging around them.
  3. Switch to a different instance of xLights with a different sequence open.
  4. Ensure the model I wish to paste the effects on has the same or more layers
  5. Turn off timing marks
  6. Select the first cell cell on the top layer where I want to paste
  7. CNTL+v to paste

Result: Only the last effect of the group of effects that was pasted will do so.

Behavior 2.

  1. Turn off timing marks.
  2. Select a model whose effect I want to copy
  3. Right-click on the model, Select Model..., Copy Effects from the context menu
  4. Switch to a different instance of xLights with a different sequence open.
  5. Ensure the model I wish to paste the effects on has the same or more layers
  6. Turn off timing marks
  7. Select Model... Paste Effects...

Result: Model... Paste Effects is greyed out.

System Configuration

  • Windows 10 (latest patch)
  • xLights 2022.26
  • CPU: AMD Ryzen 5 3rd Gen
  • RAM: 32GB
  • GPU: Nvidia GeForce RTX 2080

@AzGilrock
Copy link
Collaborator

The Paste option is greyed out until you do a copy in each instance. So do a dummy copy first in the destination instance before you copy in the first instance. We didn’t really design for multiple instances it just happens to work.

@cybercop23
Copy link
Collaborator

Can this be closed as WAD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants